AP_Mount: fix SiYi gimbal upside-down facing not working #23919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanasif786
changed the title
rmackay9
reviewed
May 29, 2023
khanasif786
force-pushed
the
direction_fix_siyi
branch
from
022bea0
to
edf9fbd
Compare
khanasif786
force-pushed
the
direction_fix_siyi
branch
from
eacb786
to
818007c
Compare
rmackay9
approved these changes
May 30, 2023
khanasif786
force-pushed
the
direction_fix_siyi
branch
from
818007c
to
c0b70af
Compare
|
I tested this and it actually made no difference for my ZR10. I believe I upgraded to the latest firmware on both the "gimbal" and "zoom". In both cases both master and this PR were able to record video. .. both also nodded though when mounted upside-down.
This leads me to believe that the extra mounting position is actually hardware version specific meaning that even if I upload new firmware to the older gimbal it cannot detect its mounting direction. @khanasif786 could you confirm what firmware you have on your gimbal/zoom? |
|
@rmackay9 Firmware is same for the gimbal. But i dont know about the boot program. |
rmackay9
reviewed
Jun 8, 2023
rmackay9
reviewed
Jun 8, 2023
khanasif786
force-pushed
the
direction_fix_siyi
branch
from
c0b70af
to
eda1304
Compare
khanasif786
force-pushed
the
direction_fix_siyi
branch
from
eda1304
to
9940ac4
Compare
rmackay9
approved these changes
Jun 8, 2023
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SiYi gimbal when facing upside-down (Put on the table or maybe rover in future) doesn't takes mounting direction into account.
This PULL fixes that by taking advantage of mounting direction information that zr10 and A8 provides.